Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve several default settings and add to README for Workbench #469

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

tnederlof
Copy link
Contributor

This PR fixes/improves several rough edges in the Workbench chart. @SamEdwardes and I went through them together and each tested the changes.

@SamEdwardes
Copy link
Contributor

I did a test deployment with these changes:

# test-values.yaml

homeStorage:
  create: true
  mount: true
  storageClassName: efs-client
  requests:
    storage: 8G

sharedStorage:
  create: true
  mount: true
  storageClassName: efs-client
  requests:
    storage: 1G
      
userCreate: true
helm upgrade --install samedwardes-workbench-test . --set-file license.file.contents="workbench.lic" --values test-values.yaml

I was able to start each IDE without issue. LGTM.

@tnederlof tnederlof merged commit 1b339d5 into main Mar 4, 2024
5 checks passed
@tnederlof tnederlof deleted the tn-workbench-config branch March 4, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants