Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPM - set default for config.Server.RVersion and config.Server.PythonVersion to "" #474

Merged
merged 7 commits into from
Mar 12, 2024

Conversation

SamEdwardes
Copy link
Contributor

@SamEdwardes SamEdwardes commented Mar 1, 2024

Description

Update the default values config.Server.RVersion and config.Server.PythonVersion to ""`. This will ensure that Package Manager uses R and Python autodetection unless the user explicitly sets the desired R or Python version in the Helm chart.

Related

Testing

I did a test deployment of the changes. I confirmed that autodetection kicked in as expected:

2024/03/01 22:34:21 Checking for newly supported operating systems and R versions
2024/03/01 22:34:21 Updated supported operating systems and R versions to latest
2024/03/01 22:34:21 Info: User namespace sandbox test successful.
2024/03/01 22:34:21 `Server.RVersion` was not set. Attempting to auto-detect.
2024/03/01 22:34:22 R 4.2.3 auto-detected on the system successfully at /opt/R/4.2.3/bin/R. To set the version manually configure the `Server.RVersion` option.
2024/03/01 22:34:22 `Server.PythonVersion` was not set. Attempting to auto-detect.
2024/03/01 22:34:22 Python 3.10.12 auto-detected on the system successfully at /usr/bin/python3. To set the version manually configure the `Server.PythonVersion` option.
2024/03/01 22:34:22 Warning: Unable to build Git packages for Python on this system: required Python modules `build`, `virtualenv` are not installed
2024/03/01 22:34:22 Posit Package Manager service is ready

@SamEdwardes SamEdwardes requested a review from tnederlof March 1, 2024 22:45
@SamEdwardes SamEdwardes self-assigned this Mar 1, 2024
@SamEdwardes SamEdwardes requested review from a team, colearendt and atheriel as code owners March 1, 2024 22:45
charts/rstudio-workbench/test-values.yaml Outdated Show resolved Hide resolved
charts/rstudio-pm/values.yaml Show resolved Hide resolved
@tylfin
Copy link
Contributor

tylfin commented Mar 5, 2024

FYI we have a fix for this in the upcoming release:

Warning: Unable to build Git packages for Python on this system: required Python modules build, virtualenv are not installed

https://github.com/rstudio/package-manager/pull/13097

@SamEdwardes SamEdwardes requested a review from tnederlof March 6, 2024 22:53
@SamEdwardes
Copy link
Contributor Author

@tnederlof thank you for the review. I made the suggested changes. Regarding what config options to document I removed R and Python from the config since we can rely on the product's default behaviour.

@shepherdjerred shepherdjerred changed the title PPM - set default for config.Server.RVersion and config.Server.PythonVersion to ""` PPM - set default for config.Server.RVersion and config.Server.PythonVersion to "" Mar 11, 2024
@SamEdwardes SamEdwardes merged commit 5fb2ad5 into main Mar 12, 2024
5 checks passed
@SamEdwardes SamEdwardes deleted the ppm-r-and-python-scanning branch March 12, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the default Package Manager config to take advantage of R and Python autodetection
5 participants