-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPM - set default for config.Server.RVersion
and config.Server.PythonVersion
to ""
#474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamEdwardes
requested review from
a team,
colearendt and
atheriel
as code owners
March 1, 2024 22:45
tnederlof
requested changes
Mar 4, 2024
FYI we have a fix for this in the upcoming release:
|
…nto ppm-r-and-python-scanning
@tnederlof thank you for the review. I made the suggested changes. Regarding what config options to document I removed R and Python from the config since we can rely on the product's default behaviour. |
tnederlof
approved these changes
Mar 6, 2024
shepherdjerred
changed the title
PPM - set default for
PPM - set default for Mar 11, 2024
config.Server.RVersion
and config.Server.PythonVersion to
""`config.Server.RVersion
and config.Server.PythonVersion
to ""
shepherdjerred
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the default values
config.Server.RVersion
andconfig.Server.PythonVersion to
""`. This will ensure that Package Manager uses R and Python autodetection unless the user explicitly sets the desired R or Python version in the Helm chart.Related
Testing
I did a test deployment of the changes. I confirmed that autodetection kicked in as expected: