Update README link for Connect config #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wydsith
requested review from
aronatkins,
dbkegley,
christierney and
zackverham
as code owners
|
@annikakrilov sorry, I forgot how this all worked 🤦♂️ . That section of the README is generated from the default helm/charts/rstudio-connect/values.yaml Lines 315 to 316 in 1b339d5 |
dbkegley
reviewed
Mar 5, 2024
dbkegley
approved these changes
Mar 5, 2024
Co-authored-by: David <[email protected]>
aronatkins
approved these changes
Mar 5, 2024
|
I merged this without bumping the chart version because it only contains branding changes in the comments in the values file which is used to generate the docs. I don't think this warrants a new chart release but CI doesn't like it. These comment changes will get picked up during the next Connect chart release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #475
"Under the Values -> Config section, the README currently points towards https://docs.posit.co/connect/admin/appendix/configuration/ which doesn't actually contain helm/K8s relevant information. Per @dbkegley , https://docs.posit.co/connect/admin/appendix/off-host/helm-reference/ is a better link to include here"
Updated the link, and cleaned up some old rebranding on the page (RStudio -> Posit)