Connect: Enable Quarto and Python by default for local execution #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkegley
force-pushed
the
kegs-test-connect-versions
branch
from
c68381c to
4a728b7
Compare
aronatkins
approved these changes
Apr 30, 2024
I didn't even notice that... @colearendt any preference on what lives in the main justfile vs the product-specific makefiles? I can move this target elsewhere if we prefer. Also, @aronatkins are you okay if I go ahead and enable quarto/python by default in this branch? I'll go ahead and update the NEWS as well. |
|
OK enabling, yes. |
dbkegley
changed the title
dbkegley
force-pushed
the
kegs-test-connect-versions
branch
3 times, most recently
from
1040944 to
fc24e26
Compare
dbkegley
force-pushed
the
kegs-test-connect-versions
branch
from
fc24e26 to
1be2b30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Quarto and Python by default for local execution. They were already enabled by default for off-host execution.This change will happen in the original PR instead. This PR only add the new GHAAdds a new GHA test that runs on every PR which validates
thatthe local defaults defined in the values are actually installed on the default image:command -vagainst each executable to ensure that it exists in the default chart image.Related to #486 (comment)