Place the helm unittests in the same directory structure as lint and install tests #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforest
requested review from
aronatkins,
dbkegley,
christierney,
zackverham and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that we do not have to bump chart versions when adding or changing tests.
This should only be needed until they release a new version of the
chart-testingtool. Last release was april 27th. The--use-helmignoreflag was added in a PR that was merged on May 22nd.Moves the existing connect tests file into the root
ci/rstudio-connect/testsdirectoryAlso adds a few tests for the serviceAccount name in the rstudio-workbench chart
Bonus slack message https://positpbc.slack.com/archives/C07HEPSEVFS/p1731611646964139