Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump launcher templates for Workbench chart to 2.5.0 #629

Closed
wants to merge 1 commit into from

Conversation

zachhannum
Copy link
Contributor

@zachhannum zachhannum commented Dec 16, 2024

Adds init containers support from the Job spec from rstudio/launcher#1070

This should go out with the other 2024.12.0 post-release changes.

Adds init containers support from the Job spec.
Copy link
Contributor

@GCRev GCRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@melissa-barca melissa-barca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachhannum
Copy link
Contributor Author

zachhannum commented Dec 16, 2024

@melissa-barca Do you want to just cherry pick this onto the PR that bumps the WB and helm chart version as a part of the release? So that it goes out with the helm chart version bump. I don't want to accidentally modify the existing helm chart version with the old release.

@melissa-barca melissa-barca mentioned this pull request Dec 17, 2024
@zachhannum
Copy link
Contributor Author

This was merged as a part of #631, so closing.

@zachhannum zachhannum closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants