Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove syntax used as a workaround while Python 3.7 was being supported #246

Conversation

nathanjmcdougall
Copy link
Contributor

I noticed a few places in the code where there were workarounds associated with Python 3.7. Since support for 3.7 has been dropped, I have refactored to remove these workarounds.

@nathanjmcdougall nathanjmcdougall force-pushed the feature/remove-3pt7-workaround-syntax branch from 8f287ac to da5fd97 Compare July 18, 2024 22:01
@isabelizimm
Copy link
Collaborator

isabelizimm commented Jul 19, 2024

Hmmm.... not sure why the CI isn't showing up here (there a dev branches that is identical to this one and run the tests from there. I think it's mad about the force push, which is a little surprising to me! But, the tests ran, just not reflected here. Sorry about that!) but this fails on Posit Connect, it looks like @functools.cached_property might not be an exact swap from @property.

If you would like, I can pick up the fix for that platform since I have access to that testing environment (probably early next week). But up to you, depending on your willingness to debug that specific platform!

@nathanjmcdougall
Copy link
Contributor Author

I think I just forgot to access the value ["username"].

Copy link
Collaborator

@isabelizimm isabelizimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you are correct--everything is running now 😄 this looks ready to go! 🚀

@isabelizimm isabelizimm merged commit 641e511 into rstudio:main Jul 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants