Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/262-add-rdata-dep #265

Merged
merged 16 commits into from
Dec 17, 2024

Conversation

nathanjmcdougall
Copy link
Contributor

To resolve #262.

@isabelizimm
Copy link
Collaborator

ah shoot, the last rdata available on Python 3.8 was 0.9, which doesn't have the same rdata.read_rds() function. The rdata.read_rds() function is just a convenience wrapper around the steps required in the older version, which is ⏬

parsed = rdata.parser.parse_file(PATH_TO_FILE)
rdata.conversion.convert(parsed)

@nathanjmcdougall nathanjmcdougall force-pushed the feature/262-add-rdata-dep branch from 4e98380 to 60ae570 Compare July 23, 2024 23:22
@nathanjmcdougall nathanjmcdougall force-pushed the feature/262-add-rdata-dep branch from e5e5e59 to 1a8a772 Compare July 25, 2024 08:04
@nathanjmcdougall
Copy link
Contributor Author

Unfortunately I needed to add a datatype conversion to use fsspec with rdata in the 3.8-compatible version of the package.

pins/drivers.py Outdated Show resolved Hide resolved
@isabelizimm
Copy link
Collaborator

(ignore connect error, that is fixed on main!)

@nathanjmcdougall nathanjmcdougall force-pushed the feature/262-add-rdata-dep branch from 277864a to 1439fec Compare August 21, 2024 03:47
@isabelizimm
Copy link
Collaborator

Ah, looks like that is a success for the local boards, I can pick up the changes for the last boards since I have credentials?

@nathanjmcdougall
Copy link
Contributor Author

Yeah that would be good! It's hard to debug this one without being able to run all the tests 🙈

@isabelizimm isabelizimm merged commit 8a4faf1 into rstudio:main Dec 17, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rdata as a test dependency
2 participants