Move to adaptor backend #298
Conversation
| } | ||
|
|
||
| # data preview ---- | ||
|
|
||
| # TODO: move out data_preview logic? Can we draw some limits here? |
There was a problem hiding this comment.
Addressing this TODO; this logic has been moved to _DFAdaptor and _Adaptor respectively.
pins/tests/_databackend/LICENSE
Outdated
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
There was a problem hiding this comment.
Technically complying with MIT requires distributing the license
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
There was a problem hiding this comment.
Actually this probably needs to be moved out of tests because I'm not sure if that gets included in the wheel build (I think it doesn't).
There was a problem hiding this comment.
The tests directory does get included in the wheel build! I'm not entirely sure where this file should be, but it might be easier to not vendor in this package, if possible 😄
pins/_adaptors.py
Outdated
| from abc import abstractmethod | ||
| from typing import TYPE_CHECKING, Any, ClassVar, TypeAlias, overload | ||
|
|
||
| from typing_extensions import Self |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
I would prefer to not vendor in all of |
nathanjmcdougall
force-pushed
the
feature/move-to-adaptor-backend
branch
from
43ebacc to
549679a
Compare
|
Okay, we are able to use databackend==0.0.3 now, rather than vendoring it all in 🎉 |
Various other type improvements
nathanjmcdougall
force-pushed
the
feature/move-to-adaptor-backend
branch
from
90355be to
fe6092f
Compare
|
Cool, I've rebased away the commit with the vendored code and added the new dependency. |
To set us up for #263 and #254.
At @machow's suggestion here: #263 (comment)
I definitely agree this is definitely a nicer way of doing things.