Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore .env virtual environments; allow .env files #973

Merged
merged 4 commits into from
Aug 23, 2023
Merged

ignore .env virtual environments; allow .env files #973

merged 4 commits into from
Aug 23, 2023

Conversation

aronatkins
Copy link
Contributor

fixes #972

@aronatkins aronatkins changed the title ignore .env directores; allow .env files ignore .env virtual environments; allow .env files Aug 23, 2023
@aronatkins aronatkins requested a review from toph-allen August 23, 2023 15:21
@aronatkins
Copy link
Contributor Author

aronatkins commented Aug 23, 2023 •
edited
Loading

related: posit-dev/rsconnect-python#207
note: we may still need to check for venv on Windows differently. (done)

@aronatkins aronatkins requested a review from mmarchetti August 23, 2023 15:32
kevinushey
kevinushey approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aronatkins aronatkins merged commit 2eda945 into main Aug 23, 2023
@aronatkins aronatkins deleted the aron-issue-972 branch August 23, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinushey kevinushey kevinushey approved these changes

@hadley hadley Awaiting requested review from hadley

@toph-allen toph-allen Awaiting requested review from toph-allen

@mmarchetti mmarchetti Awaiting requested review from mmarchetti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

My .env file is not visible when deploying app on shiny server
2 participants
@aronatkins @kevinushey