Remove the unused pandoc and TeX installations from the RSPM image #300
Conversation
Previously the image was based on rstudio/r-base, which includes TinyTeX and pandoc. However RSPM's Git builds do not build package manuals or vignettes, so we don't actually need these programs. This shaves about 300MB off the image size. The upstream rstudio/r-base image also does the following, which we replicate directly instead: * Install R from RStudio's own packages. * Set TZ=UTC. * Set the locale. Signed-off-by: Aaron Jacobs <[email protected]>
| && ln -s /opt/R/${R_VERSION}/bin/R /usr/bin/R \ | ||
| && ln -s /opt/R/${R_VERSION}/bin/Rscript /usr/bin/Rscript \ | ||
| && ln -s /opt/R/${R_VERSION}/lib/R /usr/lib/R |
There was a problem hiding this comment.
Looking at this now, I think it was a mistake that we symlinked R to the OS default /usr/bin instead of /usr/local/bin in the rstudio/r-base images. The symlink to /usr/lib also isn't necessary at all, I copy pasted that from somewhere else 😬. I don't know if any users would ever want to switch their R versions here, but using /usr/local/bin would be nice for consistency with the instructions at https://docs.rstudio.com/resources/install-r/#create-a-symlink-to-r
There was a problem hiding this comment.
Or we could remove it since RSPM doesn't need R to be on the PATH. Unless users might be running R scripts in this image.
There was a problem hiding this comment.
I doubt that users would be running R scripts in this image 😮 At least I hope that would not be the case, I guess it is possible with some type of CI / etc. but definitely not a happy path recommendation 😄
There was a problem hiding this comment.
Definitely not the happy path. I'll remove these symlinks.
There was a problem hiding this comment.
I think this is a great call, along with @glin 's recommendations. In particular, I think a NEWS entry would definitely be worthwhile
|
I'm going to wait for #270 to be merged before creating more churn with this one. |
|
|
Previously the image was based on
rstudio/r-base, which includes TinyTeX and pandoc. However RSPM's Git builds do not build package manuals or vignettes, so we don't actually need these programs.This shaves about 300MB off the image size.
The upstream
rstudio/r-baseimage also does the following, which we replicate directly instead:Install R from RStudio's own packages.
Set
TZ=UTC.Set the locale.