-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
propose new labels and data format #477
base: main
Are you sure you want to change the base?
Conversation
I like this; it could be very helpful on the Connect side when we get to image "discovery". We could search image labels within a registry to find compatible R/python/quarto versions without having to pull and run every image. |
c7e513d
to
264434f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -140,5 +140,19 @@ LABEL posit.r.version="${R_VERSION}" \ | |||
posit.python.version_alt="${PYTHON_VERSION_ALT}" \ | |||
posit.tini.version="${TINI_VERSION}" \ | |||
posit.quarto.version="${QUARTO_VERSION}" | |||
LABEL org.opencontainers.image.source = "https://github.com/rstudio/rstudio-docker-products" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we can probably make this a single LABEL
block if we want to keep the above labels, but I also wouldn't be opposed to replacing them completely since I doubt they have been heavily used yet
Would this close #455? |
BUMP ✋🏼 please may I have this? |
@meatballhat I don't know why this conversation stalled but it would be good to confirm that we still actually want this to happen before working on it. (No objections from me, though -- it sounds like it could eventually help on the discovery side in Connect/Workbench, which is cool.) |
@ianpittwood I think it could be useful to pull in all or a subset of the labels we have been working with in the build tooling update. |
I propose adding new labels to our images, and a general data format of
[{"version": "1.2.3", "path": "/path/to/install", "label": "some-label"}]
for installed software under a tagversions
.These would replace the current
posit.r.version
,posit.r.version_alt
, etc.Labels are articulated here, and seem to me like they could be a useful convention for us to explore as a way of both documenting our images and potentially integrating more smoothly into the products. Azure uses this approach as an interface into their platform, for instance.
rstudio-docker-products/workbench-for-microsoft-azure-ml/Dockerfile.ubuntu2204
Lines 163 to 174 in ff278db
https://docs.docker.com/engine/reference/builder/#label