Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Workbench 2023.09.0 #641

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Publish Workbench 2023.09.0 #641

merged 2 commits into from
Sep 27, 2023

Conversation

melissa-barca
Copy link
Contributor

No description provided.

@melissa-barca melissa-barca requested review from jonyoder and nodivbyzero and removed request for a team September 26, 2023 21:28
Copy link
Contributor

@bschwedler bschwedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @melissa-barca

Are there any other open issues that need to be merged related to this upgrade?

@melissa-barca melissa-barca changed the base branch from main to dev September 27, 2023 16:02
@melissa-barca melissa-barca requested a review from a team as a code owner September 27, 2023 16:02
@melissa-barca melissa-barca reopened this Sep 27, 2023
Currently the production version of PPM does not create
`/usr/local/bin/rspm` but the dev version does.

We allow the symlink creation to fail and log if it is already present.
@bschwedler bschwedler requested review from tylfin and removed request for a team September 27, 2023 16:30
@bschwedler
Copy link
Contributor

@tylfin @jonyoder @nodivbyzero
Could you please review the package-manager symlink changes?

Copy link
Contributor

@nodivbyzero nodivbyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rspm symlink changes look good to me!
Thank you for making those changes.

@bschwedler bschwedler merged commit 39e0b03 into dev Sep 27, 2023
88 checks passed
@bschwedler bschwedler deleted the pwb-2023.09.0 branch September 27, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants