Create trix-editor in project #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreydro
reviewed
Aug 27, 2018
| @@ -14,4 +14,4 @@ | |||
| //= require popper | |||
| //= require bootstrap-sprockets | |||
| //= require activestorage | |||
| //= require_tree . | |||
There was a problem hiding this comment.
Did you test how this deletion influences on user interface?
mrgrecha
reviewed
Aug 27, 2018
| @@ -13,6 +13,6 @@ | |||
| *= require bootstrap_and_overrides | |||
| *= require static_page | |||
| *= require _colors | |||
| *= require_tree . | |||
mrgrecha
reviewed
Aug 27, 2018
| @@ -0,0 +1 @@ | |||
| <%= field.to_s %> | |||
There was a problem hiding this comment.
Разве без to_s не работает?
По-моему, оно само приводит
There was a problem hiding this comment.
Данные вещи гинерил administrate, при создании нового field'a
mrgrecha
reviewed
Aug 27, 2018
Gemfile
Outdated
| @@ -28,6 +28,7 @@ gem "simple_form", "4.0.1" | |||
| gem "administrate", "0.10.0" | |||
| gem "will_paginate", "3.1.6" | |||
| gem "administrate-field-carrierwave", "0.3.2" | |||
| gem 'trix', "0.11.1" | |||
There was a problem hiding this comment.
Эта версия не совместима. Судя по всему, у тебя опечатка. У меня по дефолту стала 0.10.1
There was a problem hiding this comment.
trix 0.11.1
на рубигемах... Прикольно)
There was a problem hiding this comment.
Проверь, пожалуйста, работает ли у тебя на 0.11.1 и у других?
Я просто пулил и выдало ошибку.
mrgrecha
requested changes
Aug 27, 2018
andreydro
reviewed
Aug 29, 2018
| //= require cable | ||
| //= require static_page | ||
| //= require cable | ||
| //= require trix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Создавая пуллреквест, я:
diffизмненеий содержит только внесеные мной изменения