Config to ignore old migrations for Rails/ThreeStateBooleanColumn

changelog/change_config_rails_three_state_boolean.md

@@ -0,0 +1 @@
+* [#985](https://github.com/rubocop/rubocop-rails/pull/985): Add `StartAfter` config for `Rails/ThreeStateBooleanColumn` to ignore old migrations. ([@toydestroyer][])

config/default.yml

@@ -1002,6 +1002,7 @@ Rails/ThreeStateBooleanColumn:
   StyleGuide: 'https://rails.rubystyle.guide/#three-state-boolean'
   Enabled: pending
   VersionAdded: '2.19'
+  StartAfter: 0
   Include:
     - db/**/*.rb
 

lib/rubocop/cop/rails/three_state_boolean_column.rb

@@ -18,6 +18,8 @@ module Rails
       #   t.boolean :active, default: true, null: false
       #
       class ThreeStateBooleanColumn < Base
+        include MigrationsHelper
+
         MSG = 'Boolean columns should always have a default value and a `NOT NULL` constraint.'
 
         RESTRICT_ON_SEND = %i[add_column column boolean].freeze
@@ -39,6 +41,8 @@ class ThreeStateBooleanColumn < Base
         PATTERN
 
         def on_send(node)
+          return if in_migration?(node) && excluded_migration?(processed_source.file_path)
+
           three_state_boolean?(node) do |column_node, options_node|
             options_node = options_node.first
 
@@ -67,6 +71,13 @@ def table_node(node)
             ancestor&.send_node&.first_argument
           end
         end
+
+        def excluded_migration?(file_path)
+          basename = File.basename(file_path)
+          version = basename.split('_').first.to_i
+
+          version < cop_config['StartAfter'].to_i
+        end
       end
     end
   end

spec/rubocop/cop/rails/three_state_boolean_column_spec.rb

@@ -150,4 +150,31 @@ def change
       RUBY
     end
   end
+
+  context 'with StartAfter config' do
+    let(:cop_config) do
+      { 'StartAfter' => '20230415000000' }
+    end
+
+    it 'does not register an offense for old files' do
+      expect_no_offenses(<<~RUBY, 'db/migrate/20230414000000_create_users.rb')
+        class CreateUsers < ActiveRecord::Migration[7.0]
+          create_table(:users) do |t|
+            t.boolean :active
+          end
+        end
+      RUBY
+    end
+
+    it 'registers an offense for new files' do
+      expect_offense(<<~RUBY, 'db/migrate/20230415000000_create_users.rb')
+        class CreateUsers < ActiveRecord::Migration[7.0]
+          create_table(:users) do |t|
+            t.boolean :active
+            ^^^^^^^^^^^^^^^^^ Boolean columns should always have a default value and a `NOT NULL` constraint.
+          end
+        end
+      RUBY
+    end
+  end
 end