Add support for Sequel datasets #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sequel dataset do not support the `to_ary` implementation. To add support, check if `objects` is a list. `nil` and `Hash` both implement `to_a` but aren't lists themselves. Fixes #188
| root_element = root_element(:collection_root) | ||
| inner = objects.send(collection_method_name).map do |object| | ||
| new(object, options.reverse_merge(collection: true)).presented | ||
| end | ||
| else | ||
| objects = { @collection_name => objects } if @present_collection |
There was a problem hiding this comment.
I think storing the method name is strange, or at least not idiomatic. How's this?
ary = if objects.respond_to?(:to_ary)
objects.to_ary
elsif ! objects.is_a?(Hash) && objects.respond_to?(:to_a) #nil? is redundant here
objects.to_a
end
if ary && !@present_collection
root_element = root_element(:collection_root)
inner = ary.map ...
elsif @present_collection
objects = { @collection_name => objects }
end
|
You also need tests for this to be merged and a CHANGELOG entry, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequel dataset do not support the
to_aryimplementation.To add support, check if
objectsis a list.Note:
nilandHashboth implementto_abut aren't lists themselves.Fixes #188
Please let me know if this fix is ok.
Do you think only checking
nilandHashis enough?