Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version handling #152

Closed
wants to merge 2 commits into from
Closed

Add version handling #152

wants to merge 2 commits into from

Conversation

rubene
Copy link

@rubene rubene commented Oct 1, 2014

Give ability to grape-swagger to distinguish and handle multiple grape api versions.

Repurposing api_version to pull desired version from query string.
Only routes for the specified version will be returned

Possible related issues:
141
146
38

MathieuGilbert and others added 2 commits May 1, 2014 15:11
- Repurposing api_version to pull desired version from query string.
- Only routes for the specified version will be returned.
Making Swagger respect versions
@dblock
Copy link
Member

dblock commented Oct 3, 2014

This needs tests and a rebase to be merged, please.

@amerdidit
Copy link

+1

@dblock
Copy link
Member

dblock commented Dec 14, 2014

Bump.

@sunnyrjuneja
Copy link
Contributor

@dblock What's blocking this from a merge? Tests?

@dblock
Copy link
Member

dblock commented Feb 4, 2015

Yes, tests + rebase.

@dm1try
Copy link
Member

dm1try commented Feb 15, 2015

Does it work?

@bilal62
Copy link

bilal62 commented Mar 12, 2015

Hello, what's the status on this ?

@dblock
Copy link
Member

dblock commented Mar 12, 2015

There's code, no tests. Please finish this PR.

@rubene
Copy link
Author

rubene commented Mar 12, 2015

We are still looking into this, there is a javascript issue that have to be resolved for these changes to work. @MathieuGilbert @mvandenbeuken

@florrain
Copy link

florrain commented Mar 9, 2016

Bump for this, it's been a while with no update. 👊

@LeFnord
Copy link
Member

LeFnord commented Oct 26, 2016

please re-target against swagger-1.2 branch or close

@mcfilib
Copy link

mcfilib commented May 16, 2019

@rubene this is something that'd be great to have. was it ever picked up again in another pull request?

@mcfilib
Copy link

mcfilib commented May 16, 2019

We are still looking into this, there is a javascript issue that have to be resolved for these changes to work. @MathieuGilbert @mvandenbeuken

what was the javascript issue?

@zjullion
Copy link

@MathieuGilbert @mvandenbeuken @rubene I would also like to know wha the issues were, and if this will ever be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.