custom validator keeping ref to instance variable #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry: * [#1593](https://github.com/ruby-grape/grape/pull/1593): Custom validator keeping ref to instance variable - [@loicginoux](https://github.com/loicginoux).Generated by 🚫 danger |
|
@dblock This one might be closed, the related issue was fixed. |
|
@loicginoux Want to rebase and retest? Close or update if the test case is useful and I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a failing test that demonstrate a possible bug. This is a failing test in response to this issue #1592.
I have tested both from code at version
0.16.2andmasterwith similar error.Not sure if the issue is in custom validator or in the helper. I hope someone knowing better the source code can help on this.
Thanks