Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Sheet from PhlexUI to RBUI #107

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Migrate Sheet from PhlexUI to RBUI #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
601dcbb
RBUI SHEET WORKING PROPERLY
pierry01 Aug 29, 2024
53e4c92
UNDO GEMFILE & PACKAGE.JSON
pierry01 Aug 29, 2024
cf0a227
OOPS
pierry01 Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
GIT
remote: https://github.com/PhlexUI/phlex_ui.git
revision: c2b5b37964e5255df7caf55002bd0964734d6111
revision: bccfd09c75126620a65cae0560ef35ded715d1b5
branch: v1
specs:
phlex_ui (0.1.10)
Expand Down Expand Up @@ -300,7 +300,7 @@ GEM
railties (>= 6.0.0)
stringio (3.1.1)
strscan (3.1.0)
tailwind_merge (0.12.2)
tailwind_merge (0.13.0)
lru_redux (~> 1.1)
thor (1.3.1)
timeout (0.4.1)
Expand Down
4 changes: 2 additions & 2 deletions app/views/docs/sheet_view.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def view_template
Input(placeholder: "[email protected]")
end
SheetFooter do
Button(variant: :outline, data: { action: 'click->dismissable#dismiss' }) { "Cancel" }
Button(variant: :outline, data: { action: 'click->rbui--sheet-content#close' }) { "Cancel" }
Button(type: "submit") { "Save" }
end
end
Expand Down Expand Up @@ -56,7 +56,7 @@ def view_template
Input(placeholder: "[email protected]")
end
SheetFooter do
Button(variant: :outline, data: { action: 'click->dismissable#dismiss' }) { "Cancel" }
Button(variant: :outline, data: { action: 'click->rbui--sheet-content#close' }) { "Cancel" }
Button(type: "submit") { "Save" }
end
end
Expand Down
4 changes: 2 additions & 2 deletions ...onents/previews/phlex_ui/sheet_preview.rb → ...components/previews/rbui/sheet_preview.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

module PhlexUi
module Rbui
class SheetPreview < Lookbook::Preview
# Default Sheet
# ---------------
Expand All @@ -26,7 +26,7 @@ def default(side: :top, size: "")
end

SheetFooter do
Button(variant: :outline, data: {action: "click->dismissable#dismiss"}) { "Cancel" }
Button(variant: :outline, data: {action: "click->rbui--sheet-content#close"}) { "Cancel" }
Button(type: "submit") { "Save" }
end
end
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,7 +833,7 @@ queue-microtask@^1.2.2:

"rbui-js@https://github.com/PhlexUI/phlex_ui.git#v1":
version "0.0.1-alpha.0"
resolved "https://github.com/PhlexUI/phlex_ui.git#c2b5b37964e5255df7caf55002bd0964734d6111"
resolved "https://github.com/PhlexUI/phlex_ui.git#bccfd09c75126620a65cae0560ef35ded715d1b5"
dependencies:
"@floating-ui/dom" "^1.6.8"
"@hotwired/stimulus" "^3.2.2"
Expand Down