fix: Support all Ruby 2.7 for now #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby syntax `...` was added not for all 2.7 versions. Let's fallback for now to old syntax.
|
Hey! Do you consider bumping to newer ruby versions? Ruby 3.1 is end of life next week or so. Other projects, e.g. rails, start to require 3.1. This would allow using newer Ruby syntax. Additionally, you could build a new release and then bump the required version. |
|
Newer ruby syntax is not a requirement now for ferrum. There are still projects that still use 2.7. |
alanlacerda
pushed a commit
to alanlacerda/ferrum
that referenced
this pull request
Nov 26, 2024
Ruby syntax `...` was added not for all 2.7 versions. Let's fallback for now to old syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby syntax
...was added not for all 2.7 versions. Let's fallback for now to old syntax.