-
-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent submission if password not added #5241
Prevent submission if password not added #5241
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5241 +/- ##
==========================================
- Coverage 96.85% 94.19% -2.67%
==========================================
Files 456 456
Lines 9517 9577 +60
==========================================
- Hits 9218 9021 -197
- Misses 299 556 +257 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
The Pull Request description and what the diff shows are very different things. Could you please update the description to describe the change you're making? @jacklynhma edit: I see #5240 now, so I'm a bit confused to what's going on |
@colby-swandale Looks like @jacklynhma just needs to cherry-pick the last commit onto this branch, removing all the other commits for the other feature. |
@martinemde @colby-swandale Sorry about that. I am closing this PR because I opened another one that branches from latest main. #5250 |
Objective: prevent user from submitting edit form if password is not submitted