Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 314 create gateway rse list #315

Closed

Conversation

ThePhisch
Copy link
Contributor

Added listses usecase. this includes a pipelineelement that accesses the rse gateway getRSE function, which I also implemented and tested.

@ThePhisch ThePhisch force-pushed the feature-314-create_gateway_rse_list branch from f458958 to 2a25864 Compare September 6, 2023 13:26
@ThePhisch ThePhisch requested a review from maany September 6, 2023 13:40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs some implementation ;)

@ThePhisch ThePhisch requested a review from maany September 11, 2023 08:07
@ThePhisch ThePhisch force-pushed the feature-314-create_gateway_rse_list branch from 42c5237 to 2a9f752 Compare September 11, 2023 08:09
Copy link
Member

@maany maany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add a test for the API layers too :)

@ThePhisch ThePhisch closed this Sep 18, 2023
@ThePhisch
Copy link
Contributor Author

as discussed, closing this one and adding a new PR with only the gateway (i.e. primary ports and usecase removed), so you can continue there using the meow-maker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants