Skip to content

Commit

Permalink
chore: changes from review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
a-rampalli committed Jul 20, 2023
1 parent b9e1a82 commit 872c0eb
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import calendar
import functools
import logging
import math
import re
import time
from abc import ABC
Expand Down Expand Up @@ -438,7 +437,7 @@ class SourceZendeskSupportOffsetPaginationStream(SourceZendeskSupportFullRefresh
@property
def state_checkpoint_interval(self) -> Optional[int]:
"""
Will allow the connector send state messages more frequent and not only at the end of the sync.
Will allow the connector send state messages more frequently and not only at the end of the sync.
"""
return self.page_size

Expand Down Expand Up @@ -477,7 +476,7 @@ def request_params(

class SourceZendeskSupportCursorPaginationStream(SourceZendeskSupportFullRefreshStream):
"""
Only used by streams modified by rudderstack
Only used by streams supporting cursor pagination
"""

cursor_field = "updated_at"
Expand All @@ -487,7 +486,7 @@ class SourceZendeskSupportCursorPaginationStream(SourceZendeskSupportFullRefresh
@property
def state_checkpoint_interval(self) -> Optional[int]:
"""
Will allow the connector send state messages more frequent and not only at the end of the sync.
Will allow the connector send state messages more frequently and not only at the end of the sync.
"""
return self.page_size

Expand Down Expand Up @@ -524,6 +523,7 @@ def request_params(
"""
params = {
# Latest value of state is used as start_time for making api call at the beginning of every sync run where we don't have a next-page token
# start_time Not necessarily supported by all streams
"start_time": parsed_state,
"page[size]": self.page_size,
"sort_by": self.cursor_field,
Expand Down Expand Up @@ -813,7 +813,7 @@ def request_params(

@property
def state_checkpoint_interval(self) -> Optional[int]:
return math.inf
return None


class Views(SourceZendeskSupportCursorPaginationStream):
Expand Down

0 comments on commit 872c0eb

Please sign in to comment.