chore(release): pulling release/3.1.0 into main #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test (#1654) * chore: default constant for plugins and integrations base url updated * chore: updated beta path in unit test
* feat: remove beta status for all the packages * fix: mono repo version bump * chore: remove beta status from package version * chore: use user group for code owners * chore: use github runner for publishing new releases * chore: fix inconsistencies in github workflows * fix: dependency chain across all the packages and typos * fix: reset the crypto-es version * fix: crypto-js, crypto-es and vulnerable versions * chore: upgrade size-limit action to the latest version
devops-github-rudderstack
requested review from
ItsSudip,
shrouti1507,
sandeepdsvs,
koladilip,
mihir-4116,
saikumarrs and
MoumitaM
as code owners
WalkthroughThe updates focus on refining GitHub Actions workflows, enhancing documentation, and updating package versions across various components of a JavaScript SDK ecosystem. Key adjustments include transitioning to GitHub hosted runners, renaming steps for clarity, correcting "JavaScript" capitalization, and updating dependencies. These changes streamline CI/CD processes, improve readability, and ensure the SDK components are up-to-date, reflecting a commitment to maintaining a polished and efficient development pipeline. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
saikumarrs
approved these changes
Mar 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
=======================================
Coverage 53.89% 53.89%
=======================================
Files 461 461
Lines 15588 15588
Branches 3097 3105 +8
=======================================
Hits 8401 8401
+ Misses 5881 5833 -48
- Partials 1306 1354 +48 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (19)
migrations.jsonis excluded by:!**/*.jsonpackage-lock.jsonis excluded by:!**/*.jsonpackage.jsonis excluded by:!**/*.jsonpackages/analytics-js-common/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-common/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-integrations/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-integrations/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-service-worker/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-service-worker/project.jsonis excluded by:!**/*.jsonpackages/analytics-js/package.jsonis excluded by:!**/*.jsonpackages/analytics-js/project.jsonis excluded by:!**/*.jsonpackages/analytics-v1.1/package.jsonis excluded by:!**/*.jsonpackages/analytics-v1.1/project.jsonis excluded by:!**/*.jsonpackages/loading-scripts/package.jsonis excluded by:!**/*.jsonpackages/loading-scripts/project.jsonis excluded by:!**/*.jsonpackages/sanity-suite/package.jsonis excluded by:!**/*.jsonpackages/sanity-suite/project.jsonis excluded by:!**/*.json
Files selected for processing (31)
- .github/workflows/deploy-npm.yml (2 hunks)
- .github/workflows/deploy-prod.yml (6 hunks)
- .github/workflows/deploy-staging.yml (1 hunks)
- .github/workflows/publish-new-release.yml (1 hunks)
- .github/workflows/security-code-quality-and-bundle-size-checks.yml (1 hunks)
- CODEOWNERS (1 hunks)
- packages/analytics-js-common/CHANGELOG.md (1 hunks)
- packages/analytics-js-common/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-common/README.md (1 hunks)
- packages/analytics-js-integrations/CHANGELOG.md (1 hunks)
- packages/analytics-js-integrations/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-integrations/README.md (1 hunks)
- packages/analytics-js-plugins/CHANGELOG.md (1 hunks)
- packages/analytics-js-plugins/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-plugins/README.md (1 hunks)
- packages/analytics-js-service-worker/CHANGELOG.md (1 hunks)
- packages/analytics-js-service-worker/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-service-worker/README.md (1 hunks)
- packages/analytics-js/CHANGELOG.md (1 hunks)
- packages/analytics-js/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js/README.md (1 hunks)
- packages/analytics-js/tests/components/configManager/cdnPaths.test.ts (1 hunks)
- packages/analytics-js/src/constants/urls.ts (1 hunks)
- packages/analytics-v1.1/CHANGELOG.md (1 hunks)
- packages/analytics-v1.1/CHANGELOG_LATEST.md (1 hunks)
- packages/loading-scripts/CHANGELOG.md (1 hunks)
- packages/loading-scripts/CHANGELOG_LATEST.md (1 hunks)
- packages/loading-scripts/README.md (1 hunks)
- packages/sanity-suite/CHANGELOG.md (1 hunks)
- packages/sanity-suite/README.md (1 hunks)
- sonar-project.properties (1 hunks)
Files skipped from review due to trivial changes (19)
- packages/analytics-js-common/README.md
- packages/analytics-js-integrations/CHANGELOG.md
- packages/analytics-js-integrations/README.md
- packages/analytics-js-plugins/CHANGELOG.md
- packages/analytics-js-plugins/CHANGELOG_LATEST.md
- packages/analytics-js-plugins/README.md
- packages/analytics-js-service-worker/CHANGELOG.md
- packages/analytics-js-service-worker/CHANGELOG_LATEST.md
- packages/analytics-js-service-worker/README.md
- packages/analytics-js/CHANGELOG.md
- packages/analytics-js/CHANGELOG_LATEST.md
- packages/analytics-js/README.md
- packages/analytics-v1.1/CHANGELOG.md
- packages/loading-scripts/CHANGELOG.md
- packages/loading-scripts/CHANGELOG_LATEST.md
- packages/loading-scripts/README.md
- packages/sanity-suite/CHANGELOG.md
- packages/sanity-suite/README.md
- sonar-project.properties
Additional comments: 20
CODEOWNERS (1)
- 1-1: The update to the
CODEOWNERSfile looks good. Please ensure that@rudderlabs/js-sdkis an existing GitHub user or team with the appropriate permissions for the directory in question.packages/analytics-js-common/CHANGELOG_LATEST.md (1)
- 1-1: The version update in the
CHANGELOG_LATEST.mdforanalytics-js-commonis aligned with the PR objectives. Please ensure that the removal of features related to fetching an anonymous ID by cookie name and onboarding a new destination called ninetailed has been thoroughly discussed and agreed upon by the team.packages/analytics-v1.1/CHANGELOG_LATEST.md (1)
- 1-5: The dependency update for
@rudderstack/analytics-js-commonto version2.48.3in theCHANGELOG_LATEST.mdforanalytics-v1.1is aligned with the PR objectives. Please ensure compatibility with this new version has been thoroughly tested.packages/analytics-js-integrations/CHANGELOG_LATEST.md (1)
- 1-5: The version update to
3.0.1and the dependency update for@rudderstack/analytics-js-commonto version3.0.0in theCHANGELOG_LATEST.mdforanalytics-js-integrationsare aligned with the PR objectives. Please ensure compatibility with these updates has been thoroughly tested.packages/analytics-js/src/constants/urls.ts (1)
- 7-8: The update to production URLs in
urls.tsis aligned with the PR objectives. Please ensure that these URLs are correct and accessible..github/workflows/security-code-quality-and-bundle-size-checks.yml (1)
- 26-26: The update to version
v2.10.0of thegithub-action-check-size-limitaction is aligned with the PR objectives. Please ensure that the workflow's functionality has been verified with this new version.packages/analytics-js/__tests__/components/configManager/cdnPaths.test.ts (1)
- 64-64: The modification to use the
dummyVersionvariable directly in thegetIntegrationsCDNPathtest assertion is a good improvement for maintainability. Please ensure that this change accurately reflects the intended behavior of thegetIntegrationsCDNPathfunction..github/workflows/publish-new-release.yml (1)
- 16-16: The update to use
ubuntu-latestfor the "Publish new release" job is aligned with the PR objectives. Please ensure that the workflow's functionality has been verified with this new runner environment..github/workflows/deploy-staging.yml (3)
- 72-72: The change in the step name for syncing files to S3 staging directory improves clarity.
- 80-80: The change in the step name for creating Cloudfront invalidation is clear and concise.
- 85-85: The change in the step name for syncing files to S3 v1.1 staging directory is appropriate and enhances clarity.
.github/workflows/deploy-npm.yml (2)
- 21-21: Switching to GitHub hosted runners for NPM package publishing is a good practice for security and reliability.
- 75-75: The change in the step name for sending a message to the Slack channel is minor and acceptable.
packages/analytics-js-common/CHANGELOG.md (1)
- 5-6: The version bump from 3.0.0-beta.19 to 3.0.1 is documented correctly, following semantic versioning principles.
.github/workflows/deploy-prod.yml (6)
- 98-98: Renaming the step from "Sync files to S3 v3 folder" to "Sync files to S3" simplifies the step name and removes the version-specific reference, which could make the workflow more maintainable in the long term.
- 110-110: Renaming the step to "Sync files to S3 versioned directory" clarifies the action being performed and aligns the terminology ("directory" instead of "folder"), which is more commonly used in the context of AWS S3.
- 122-122: Updating the comment to refer to the '/latest' directory instead of '/latest' folder aligns with the consistent use of terminology across the workflow. It's also a good practice to note potential future changes in comments for maintainability.
- 137-137: Renaming the step to "Send message to Slack channel" removes the version-specific reference, making it applicable for any future versions without needing to update the step name. This change contributes to the workflow's maintainability.
- 172-172: Renaming the step to "Sync files to S3 v1.1 directory" improves clarity and aligns with the consistent terminology used throughout the workflow. It's important to maintain consistency in terminology for better readability and maintainability.
- 187-187: The renaming of the step to "Sync files to S3 v1.1 versioned directory" not only aligns with the consistent use of terminology but also clarifies the action being performed. This change enhances the readability and maintainability of the workflow.
size-limit report 📦
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👑 An automated PR
Summary by CodeRabbit
CODEOWNERSfile to reflect updated ownership of a specific directory.