Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade packages #3473

Closed
wants to merge 6 commits into from
Closed

chore: upgrade packages #3473

wants to merge 6 commits into from

Conversation

koladilip
Copy link
Contributor

What are the changes introduced in this PR?

Upgrade Workflow and JSON template engines

What is the related Linear task?

Resolves INT-2240

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@koladilip koladilip requested review from sivashanmukh and a team as code owners June 17, 2024 14:06
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 95.15419% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.03%. Comparing base (3aee494) to head (8bd44fa).
Report is 5 commits behind head on develop.

Files Patch % Lines
...c/cdk/v2/destinations/klaviyo_bulk_upload/utils.js 90.90% 3 Missing and 1 partial ⚠️
src/util/utils.js 0.00% 2 Missing ⚠️
src/controllers/delivery.ts 83.33% 1 Missing ⚠️
src/services/destination/postTransformation.ts 87.50% 1 Missing ⚠️
src/util/redis/redisConnector.js 83.33% 1 Missing ⚠️
...gle_adwords_enhanced_conversions/networkHandler.js 93.33% 1 Missing ⚠️
...ogle_adwords_offline_conversions/networkHandler.js 97.14% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3473      +/-   ##
===========================================
+ Coverage    88.00%   88.03%   +0.03%     
===========================================
  Files          572      574       +2     
  Lines        30910    31056     +146     
  Branches      7385     7410      +25     
===========================================
+ Hits         27202    27340     +138     
- Misses        3398     3405       +7     
- Partials       310      311       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

utsabc
utsabc previously approved these changes Jun 17, 2024
sanpj2292
sanpj2292 previously approved these changes Jun 18, 2024
yashasvibajpai and others added 4 commits June 18, 2024 16:29
* feat: onboard klaviyo bulk upload destination, initial commit

* chore: update router transformation logic

* chore: refactor logic

* chore: refactor logic

* add location object support

* chore: refactor klaviyo id and anonymous id logic

* chore: add processor tests

* chore: add jobidentifier logic

* chore: fix exports, tests, rtflow removed

* chore: address review comments, refactor

* chore: add custom properties

* chore: add email identifier for klaviyo bulk
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@koladilip koladilip closed this Jun 18, 2024
@koladilip koladilip deleted the chore.upgrade-pkgs branch June 18, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants