text: Do not show text that's missing an embedded font

Flash Player does not show any text that requires an embedded font that is missing.
ruffle-rs · Dec 8, 2024 · 92d88e2 · 92d88e2
1 parent 0e40550
commit 92d88e2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/core/src/html/layout.rs b/core/src/html/layout.rs
@@ -660,10 +660,10 @@ impl<'a, 'gc> LayoutContext<'a, 'gc> {
             {
                 return font;
             }
-            // TODO: If set to use embedded fonts and we couldn't find any matching font, show nothing
-            // However - at time of writing, we don't support DefineFont4. If we matched this behaviour,
-            // then a bunch of SWFs would just show no text suddenly.
-            // return new_empty_font(context, span, self.font_type);
+
+            // If set to use embedded fonts and we couldn't find any matching font, show nothing.
+            tracing::warn!("Embedded font not found: {font_name}, using an empty font");
+            return new_empty_font(context, span, self.font_type);
         }
 
         // Check if the font name is one of the known default fonts.

diff --git a/tests/tests/swfs/fonts/embed_matching/no_font_found/test.toml b/tests/tests/swfs/fonts/embed_matching/no_font_found/test.toml
@@ -1,7 +1,6 @@
 # There are no fonts embedded in this swf. It should not render anything at all, or error.
 
 num_frames = 1
-known_failure = true # Right now we intentionally fall back, because we don't support DefineFont4 embedded fonts yet
 
 [image_comparisons.output]
 tolerance = 0

diff --git a/tests/tests/swfs/visual/fonts/font_lookup_as3/output.expected.png b/tests/tests/swfs/visual/fonts/font_lookup_as3/output.expected.png