Update to winit 0.29 #13731
Closed
Update to winit 0.29 #13731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
force-pushed
the
winit-0.29
branch
from
5fea585 to
b3f9ad5
Compare
This was referenced Oct 30, 2023
1 task
This was referenced Nov 20, 2023
torokati44
force-pushed
the
winit-0.29
branch
from
b3f9ad5 to
b27f23e
Compare
1 task
|
New egui PR is emilk/egui#3649 |
torokati44
force-pushed
the
winit-0.29
branch
from
b27f23e to
0278cdf
Compare
This was referenced Dec 25, 2023
This was referenced Jan 8, 2024
3 tasks
torokati44
commented
Jan 11, 2024
| egui_extras = { version = "0.24.2", optional = true } | ||
| egui_extras = { version= "0.25", optional = true } |
There was a problem hiding this comment.
Oh no, that space must not be removed!!
|
Closing in favor of #14703. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much WIP:
The reworked Keyboard handling is, for example, mostly just commented out.
Also there is something wrong with resizing the window, at least on Linux+Wayland.
See the upstream changes here: rust-windowing/winit@v0.28.7...v0.29.9
And here: https://github.com/rust-windowing/winit/blob/master/CHANGELOG.md#0299 (all the way from 0.28.7)
Feel free to force-push this branch if any of you continue working on this!
Currently blocked by: emilk/egui#3649Currently waiting foregui0.25: https://github.com/emilk/egui/milestone/3It just got released, unblocking this! https://github.com/emilk/egui/releases/tag/0.25.0