Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on Wayland #14362

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix panic on Wayland #14362

merged 2 commits into from
Dec 11, 2023

Conversation

bi4k8
Copy link
Contributor

@bi4k8 bi4k8 commented Dec 11, 2023

When running current ruffle HEAD on Wayland, I get an error popup with the following contents:

Ruffle has encountered a fatal error, this is a bug.

panicked at desktop/src/player.rs:147:22:
Couldn't create ui backend: Couldn't get platform clipboard

Caused by:
Unknown error while interacting with the clipboard: Display parsing error

Please report this to us so that we can fix it. Thank you!

This appears to be caused by using the "arboard" crate without the feature flag required for its Wayland support: 1Password/arboard#98

This PR enables this feature and fixes the panic.

@n0samu
Copy link
Member

n0samu commented Dec 11, 2023

Thanks so much! I think this should also help unblock #9220.

@torokati44
Copy link
Member

Thank you, and welcome to the project!

Interestingly, I've been running Ruffle on Wayland for well over a year now, and never had any issues with it, even the clipboard works just fine (at least for text), both in Weston and KDE.

But this is entirely fine to do, if it indeed helps others, and even the Flatpak issue linked above.

One thing is, please tag the commit messages as advised by CONTRIBUTING.md. I'll fix it this time, as I'm going to squash your commits on merge anyway.

@torokati44 torokati44 enabled auto-merge (squash) December 11, 2023 09:52
@torokati44 torokati44 merged commit 4d07e43 into ruffle-rs:master Dec 11, 2023
13 checks passed
@torokati44 torokati44 mentioned this pull request Dec 11, 2023
5 tasks
@bi4k8
Copy link
Contributor Author

bi4k8 commented Feb 4, 2024

Interestingly, I've been running Ruffle on Wayland for well over a year now, and never had any issues with it, even the clipboard works just fine (at least for text), both in Weston and KDE.

If you have XWayland around, clipboard integration probably worked for you through the X11 codepaths. I don't use XWayland so I noticed the missing native clipboard support.

One thing is, please tag the commit messages as advised by CONTRIBUTING.md. I'll fix it this time, as I'm going to squash your commits on merge anyway.

My mistake--I'll follow convention if I have anything else to PR. Thanks for the project!

@bi4k8 bi4k8 deleted the patch-1 branch February 4, 2024 20:03
Doomsdayrs added a commit to Doomsdayrs/flathub that referenced this pull request Feb 14, 2024
This reverts commit 058f063.

It seems that I did not fully test out the changes made by,
 ruffle-rs/ruffle#14362

Upstream report:
 ruffle-rs/ruffle#15213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants