avm2: Implement Matrix3D with 2D support only #18888
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
from
7473740 to
ac547ca
Compare
cookie-s
changed the title
kjarosh
added
A-avm2
cookie-s
commented
Dec 7, 2024
There was a problem hiding this comment.
This log is taken from Adobe Flash Player 32.
There was a problem hiding this comment.
I obtained this PNG file by mv output.actual*.png output.expected.png, after verifying FP shows the very similar image by my eyes. Is that sufficient or is there a way to get screenshot directly from FP?
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
from
ac547ca to
69f6554
Compare
|
#18908 produced Git conflict with this PR and it actually implemented a kind of "2D/3D switch" inside DisplayObject. Rebased and followed its design now. |
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
from
69f6554 to
34bcfae
Compare
Replace stubs for flash.geom.Transform.matrix3D getter/setter with an actual implementation of Matrix3D with limited support. This implementation is just a proxy to the existing 2D matrix implementation. Therefore transformations beyond 2D transformation works differently from the expected result.
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
from
34bcfae to
a3a3018
Compare
Co-authored-by: Kamil Jarosz <[email protected]>
cookie-s
force-pushed
the
matrix3d-transformation-with-2d-only
branch
from
a3a3018 to
6417e5f
Compare
|
Rebased. Thanks to #18911 , this PR gets much slim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry #18810 .
Partially resolves #8033 .
#18810 (comment)
Commits
perspectiveProjection,matrix3Dstubs #18908 : 2D/3D switch ( https://docs.ruffle.rs/en_US/FlashPlatform/reference/actionscript/3/flash/geom/Transform.html#matrix3D ).