Hotfix/build imports issue fix #556
Conversation
Codecov Report
@@ Coverage Diff @@
## main #556 +/- ##
==========================================
+ Coverage 74.10% 74.36% +0.26%
==========================================
Files 100 100
Lines 6479 6479
==========================================
+ Hits 4801 4818 +17
+ Misses 1678 1661 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
opta.spec
Outdated
| @@ -4,7 +4,37 @@ from PyInstaller.utils.hooks import collect_data_files | |||
|
|
|||
| block_cipher = None | |||
|
|
|||
|
|
|||
| himps = [ | |||
There was a problem hiding this comment.
can we sort this list for maintenance?
also it can be broken into 3 lists for each cloud providers
There was a problem hiding this comment.
Can we instead have a function which generates this list
There was a problem hiding this comment.
@RemyDeWolf @NitinAgg great suggestions! Addressed both in new commit.
bigbitbus
force-pushed
the
hotfix/build-imports-issue-fix
branch
from
dfd48dc
to
fb4cefb
Compare
|
Passing tests here - https://app.circleci.com/pipelines/github/run-x/opta/514/workflows/293fb6de-d40d-46e8-9382-b485669a5d0b Ignore the redis test - its the expiring aws eks credentials issue hashicorp/terraform#29182 |
opta.spec
Outdated
|
|
||
| block_cipher = None | ||
|
|
||
| himps = generate_module_import_array() | ||
| # himps = [ |
There was a problem hiding this comment.
nit: remove these comments?
Description
Explicitly import modules when building opta binary since dynamic imports are not detected by pyinstaller.
Safety checklist
How has this change been tested, beside unit tests?
Manually