Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file permissions and attributes #122

Closed
wants to merge 2 commits into from

Conversation

YvesW
Copy link
Member

@YvesW YvesW commented Mar 10, 2024

Aims to reduce support traffic and improve user experience by:

  1. detecting and fixing filesystem permission (ACL/ACE related) and attribute (e.g. read only) problems, and
    2. detecting and fixing login problems when the user launches RL with elevated permissions via a Jagex Launcher instance that's not running with elevated permissions Edit: dropped 2 and PRed again separately as requested.

Please do test these changes by breaking your permissions in a VM. In my testing, I broke my Windows user profile before I could break RL, but there are only so many way to break your file system that I could think of.

Regarding testing I recommend at least trying the following steps:
WARNING: THIS TESTING PROCEDURE MIGHT BREAK YOUR USERPROFILE ON THE VM AFTER REBOOTING

  1. Create a fresh windows VM
  2. Create a new local user with admin rights so it's nbd if it gets bricked
  3. Install the updated launcher
  4. Set .runelite to read only
  5. To remove all permissions for your user account for .runelite and even all permissions for the subdirectory & files:
icacls "%userprofile%\.runelite" /remove vmComputerNameHere\vmAccountNameHere /inheritance:r /t /c
  1. To remove permissions for your user account for %userprofile%:
icacls "%userprofile%" /remove DESKTOP-QSUTV7K\LauncherTest2 /c
  1. Start RL & follow the on-screen instructions
  2. Success/failure
  3. Afterwards you could try running the following commands to try to prevent bricking your userprofile:
icacls "%userprofile%" /grant:r vmComputerNameHere\vmAccountNameHere :F /inheritance:r /t /c
icacls "%userprofile%" /grant:r *S-1-5-18:F /inheritance:r /t /c
icacls "%userprofile%" /grant:r *S-1-5-32-544:F /inheritance:r /t /c

@YvesW YvesW force-pushed the launcher-fix-perms branch from 2740cee to dea071e Compare March 10, 2024 16:53
@Adam-
Copy link
Member

Adam- commented Mar 17, 2024

added in d18cd88 / bd52052

@Adam- Adam- closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants