Set processed_link_refs to true only in setup or constructor
#916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automergerpr-permission-manager
bot
deleted the
fix-library-deployment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #861 and #838.
This PR fixes an issue identified by @lisandrasilva, where the second of two proofs calling a dynamically linked library fails when they're executed sequentially. The
<accounts>cell of the second proof is missing an account corresponding to the library, which is present when the proof is run in isolation (or with-j2in parallel with the first one) and the proof is then passing.This PR changes the logic of re-deploying dynamically linked libraries by ensuring it doesn't happen only if we've run
initorsetUpmethod for a contract, in which case it'll be grafted onto the proof; otherwise, the libraries will be deployed for every individual proof.It also adds a second test
testSumtoExternalLibTest.