-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solaris 11 compatibility #224
base: master
Are you sure you want to change the base?
Conversation
An even better idea: only run uname once, when the script is sourced, and only define the awk() function on Solaris:
|
fasd's method seems even better: pick an available version of |
72bbf69
to
6843d28
Compare
Solaris |
i kinda suck at github flow - could you squash these commits so I can get a better look at them? |
993746e
to
ebb29b9
Compare
@rupa Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This additional complexity seems iffy considering the userbase of Solaris 11.
I think it would be a shame to give up on POSIX compliance ( |
z
requires a version ofawk
that has the-v
option. Solaris 11 uses by default an antiquated version ofawk
that does not have that option. Itsnawk
does have-v
, however. I propose adding the functionIt simply redirects calls on awk to nawk on Solaris and should have no effect on other systems. I have tested it with both
bash
andzsh
.