Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve errors #601

Closed
wants to merge 2 commits into from
Closed

Improve errors #601

wants to merge 2 commits into from

Commits on Apr 18, 2023

  1. Remove derives from error types 

    Now that we have `matches` because of the recent MSRV bump we can
ergonomically test error types without using `PartialEq`/`Eq`.

Remove all derives from error types except `Debug`.
    @tcharding
    tcharding committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    645238f View commit details
    Browse the repository at this point in the history

  2. Refactor source method 

    Do trivial refactor to reduce the clutter in the `source` method.

Refactor only, no logic changes.
    @tcharding
    tcharding committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    3caefd7 View commit details
    Browse the repository at this point in the history