Don't recommend supporting eh0.2 #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's also worth bringing https://github.com/ryankurte/embedded-hal-compat into this. |
It's mentioned in the next section, unless you meant to include it in this section as well? |
Dirbaio
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the recommendation to add 0.2 impls into HALs.
It keeps the instructions but modifies them slightly to put it behind a feature so that we don't recommend third party HALs violate C-STABLE. How important C-STABLE is for trait implementations is debatable but I still don't think we, as a rust working group, should be recommending use of a 0.2 version of a crate when a 1.0 exists.
Alternatives
We remove this section completely and leave it to HAL authors