Add independent flags to C or C++ files #1019
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
requested changes
Mar 28, 2024
| extra_args = &self.cpp_args; | ||
| } | ||
| } | ||
| _ => {} |
There was a problem hiding this comment.
It seems that the c_flags and cpp_flags are ignored for msvc?
There was a problem hiding this comment.
MSVC has only one cl.exe and has no special parameters for C or C++, so it can be ignored.
There was a problem hiding this comment.
It doesn't have -std=c11 which is used in example?
| /// .cpp_flag("-std=c++17") | ||
| /// .compile("foo"); | ||
| /// ``` | ||
| pub fn cpp_flag(&mut self, flag: &str) -> &mut Build { |
There was a problem hiding this comment.
I think cxx_flags makes more sense.
cpp could be confused with pre-processors of C/C++ compiler.
Comment on lines
+1827
to
+1872
| for flag in self.c_flags.iter() { | ||
| cmd.c_args.push((**flag).into()); | ||
| } | ||
|
|
||
| for flag in self.cpp_flags.iter() { | ||
| cmd.cpp_args.push((**flag).into()); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think you need to do this in get_base_compiler, there are some functions which call it directly.
Signed-off-by: Varphone Wong <[email protected]>
…lset Signed-off-by: Varphone Wong <[email protected]>
NobodyXu
requested changes
May 31, 2024
| /// | ||
| /// The `src` argument is used to determine the preferred compiler for the | ||
| /// source file. If `None`, the default compiler is used. | ||
| pub fn to_command(&self, src: Option<&PathBuf>) -> Command { |
There was a problem hiding this comment.
This is breaking change, please move this to a new function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature for C/C++ flags, primarily to support the compilation of mixed C/C++ code.
Sometimes we use both C and C++ languages in a single project. However, the compilers for C and C++ are different, so we need to specify different compilers during compilation. This PR adds independent compiler flags for C and C++ files, allowing us to specify different compilers during compilation.
The main changes in this PR are as follows:
Build::c_flag()andBuild::cpp_flag()methods to add independent flags to C or C++ files.srcargument toTool::to_command()method to auto-detect c/cpp compiler by source file extension for Clang/Gnu toolset.