-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MODULE_INIT_COMPRESSED_FILE definition #3782
base: main
Are you sure you want to change the base?
Add MODULE_INIT_COMPRESSED_FILE definition #3782
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
3f870fa
to
a9c80e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a9c80e2
to
0663010
Compare
It looks like there may be some platforms where this isn't available. Could you please take a look at the failures on the latest CI? @rustbot author |
It looks like |
@sinkingpoint could you rebase to get a fresh run of tests? This probably just needs something added in |
0663010
to
cb167da
Compare
Signed-off-by: sinkingpoint <[email protected]>
cb167da
to
8b35a41
Compare
I pushed your branch with a rebase just to get fresh CI. Seems like this will need to be disabled on at least a few platforms. |
☔ The latest upstream changes (presumably #4132) made this pull request unmergeable. Please resolve the merge conflicts. |
This adds in the definition for MODULE_INIT_COMPRESSED_FILE so that we can use it in the init_module class of functions to load compressed modules
Fixes #3781