Use -0.0 as the neutral additive float #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume this resolves #432 |
|
yep, tests might require a bit of punching first. |
|
I think you just need to bump rust-toolchain.toml |
-0.0 + 0.0 is 0.0 -0.0 + -0.0 is -0.0 Thus, the float additive-zero is actually -0.0, not its positive cousin. This change aligns with a recent change to the impl of Sum for floats, in rust-lang/rust@4908188 and accordingly we also have to use the latest toolchain for our tests now.
workingjubilee
force-pushed
the
plus-minus-zero
branch
from
72031b0 to
00c3b6d
Compare
|
Oh, yep. That does it, thanks! |
|
Pretty sure the arm failure is unrelated to your changes, looks like std might have added an extra step to is_normal that causes it to flush subnormals? |
|
Oh yeah those tests are gonna be absolutely busted for thumbv7neon. |
|
I've simply cfg'd those out for now. |
workingjubilee
force-pushed
the
plus-minus-zero
branch
from
6d198cf to
00c3b6d
Compare
|
oh, that doesn't work at all, heh. |
|
There. |
workingjubilee
force-pushed
the
plus-minus-zero
branch
from
02f9f87 to
c080ba5
Compare
|
It's actually scalars that changed, it seems... |
|
Yes, probably. |
calebzulawski
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-0.0 + 0.0 is 0.0
-0.0 + -0.0 is -0.0
Thus, the float additive-zero is -0.0, not its positive cousin. This aligns with a recent change to the impl of Sum for floats, in rust-lang/rust@4908188
Fixes #432