Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section dedicated to Edition 2024 changes to temporary scopes #1592

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dingxiangfei2009
Copy link

@dingxiangfei2009 dingxiangfei2009 commented Aug 28, 2024

Tracked by rust-lang/rust#124085
Tracked by rust-lang/rust#123739

cc @traviscross coordinating Edition 2024 project

This PR introduces two changes to the language reference, to better illustrate the new Edition 2024 rules on temporary scopes.

@dingxiangfei2009 dingxiangfei2009 marked this pull request as ready for review August 28, 2024 16:08
@dingxiangfei2009 dingxiangfei2009 force-pushed the temporary-lifetime-rule-edition-2024 branch from 0eab656 to 2b54faf Compare August 28, 2024 16:11
@ehuss ehuss added S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository A-edition-2024 Area: Edition 2024 labels Sep 3, 2024
dingxiangfei2009 and others added 5 commits November 22, 2024 07:43
The reference isn't intended to have guide-like material. Most of this
should be covered in the edition guide.
The style of the reference is to document the latest edition in the main
body of the text, and any differences in a separate block. As a
compromise, I included links to the edition description.
@ehuss ehuss force-pushed the temporary-lifetime-rule-edition-2024 branch from 2b54faf to 3151ddb Compare November 22, 2024 18:19
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed some changes to align this with the way we document the edition differences, and to update some places that were now out-of-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edition-2024 Area: Edition 2024 S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants