-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish from GitHub release page #2645
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshepang
force-pushed
the
publish-from-release-page
branch
2 times, most recently
from
October 11, 2023 12:48
3362bd0
to
d87e89a
Compare
pvdrz
requested changes
Nov 1, 2023
.github/workflows/publish.yml
Outdated
uses: dtolnay/rust-toolchain@master | ||
with: | ||
toolchain: stable | ||
- name: Publish bindden (lib) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a typo! 🤣
.github/workflows/publish.yml
Outdated
toolchain: stable | ||
- name: Publish bindden (lib) | ||
run: cargo publish --package bindgen --token ${CRATES_TOKEN} | ||
- name: Publish bindden-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
tshepang
commented
Nov 1, 2023
tshepang
commented
Nov 1, 2023
pvdrz
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results in requiring a manual button push to publish to crates.io, to avoid having published crates if there is a failed release workflow.