Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish from GitHub release page #2645

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Sep 21, 2023

This results in requiring a manual button push to publish to crates.io, to avoid having published crates if there is a failed release workflow.

@tshepang tshepang marked this pull request as ready for review October 11, 2023 12:38
@tshepang tshepang force-pushed the publish-from-release-page branch 2 times, most recently from 3362bd0 to d87e89a Compare October 11, 2023 12:48
uses: dtolnay/rust-toolchain@master
with:
toolchain: stable
- name: Publish bindden (lib)
Copy link
Contributor

@pvdrz pvdrz Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a typo! 🤣

toolchain: stable
- name: Publish bindden (lib)
run: cargo publish --package bindgen --token ${CRATES_TOKEN}
- name: Publish bindden-cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@pvdrz pvdrz merged commit 04fa393 into rust-lang:main Nov 1, 2023
31 of 32 checks passed
@tshepang tshepang deleted the publish-from-release-page branch November 1, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants