Introduce ParseCallbacks::header_file
#2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Emann
reviewed
Sep 30, 2023
|
|
||
| impl CargoCallbacks { | ||
| /// Create a new `CargoCallbacks` value. | ||
| pub fn new() -> Self { |
There was a problem hiding this comment.
Could make this const, and use new in the deprecated const as well?
There was a problem hiding this comment.
I'm a bit conservative with const fns as removing the const in the future will always be a breaking change and I'm not sure if new fields added in the future could be initialized as consts or not.
pvdrz
changed the title
ParseCallbacks::input_fileParseCallbacks::header_file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2643