Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a customization to default to workspace or local crate. #546

Merged
merged 2 commits into from
May 20, 2024

Conversation

bradneuman
Copy link
Contributor

Adds rust-locate-project-in-workspace custom variable, which controls whether or not to locate the workspace project using --workspace (the default) or not.

In cases where there is only one create, this should make no difference.

The default setting should match the existing behavior.

Github issue #545

Adds rust-locate-project-in-workspace custom variable, which controls whether or not to locate the workspace
project using `--workspace` (the default) or not.

In cases where there is only one create, this should make no difference.

The default setting should match the existing behavior.

Github issue rust-lang#545
@bradneuman bradneuman changed the title Adds a customization to default to workspace or local crate. Adds a customization to default to workspace or local crate. May 14, 2024
@bradneuman bradneuman changed the title Adds a customization to default to workspace or local crate. Adds a customization to default to workspace or local crate. May 14, 2024
rust will search for the Cargo.toml in the local crated"
:type 'boolean
:group 'rust-mode)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we change this to rust-cargo-locate-default-arguments ? It's default value could be (list "--workspace"). For your specific use case, you can pass it as nil.

This will give you the ability to pass any arbitrary arguments to locate-project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@psibi psibi merged commit d00d83d into rust-lang:master May 20, 2024
16 of 17 checks passed
@psibi
Copy link
Member

psibi commented May 20, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants