Skip to content

Commit

Permalink
Rollup merge of #123496 - lcnr:wf-ping, r=compiler-errors
Browse files Browse the repository at this point in the history
ping on wf changes, remove fixme

extend core type system pings to `wf.rs`

r? `@compiler-errors`
  • Loading branch information
GuillaumeGomez authored Apr 5, 2024
2 parents b0ca3cd + 6db7ac6 commit 9cb517a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 0 additions & 2 deletions compiler/rustc_trait_selection/src/traits/wf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -714,8 +714,6 @@ impl<'a, 'tcx> TypeVisitor<TyCtxt<'tcx>> for WfPredicates<'a, 'tcx> {
// perfect and there may be ways to abuse the fact that we
// ignore requirements with escaping bound vars. That's a
// more general issue however.
//
// FIXME(eddyb) add the type to `walker` instead of recursing.
let fn_sig = tcx.fn_sig(did).instantiate(tcx, args);
fn_sig.output().skip_binder().visit_with(self);

Expand Down
8 changes: 6 additions & 2 deletions triagebot.toml
Original file line number Diff line number Diff line change
Expand Up @@ -469,11 +469,11 @@ message = "Some changes occurred in need_type_info.rs"
cc = ["@lcnr"]

[mentions."compiler/rustc_middle/src/ty/relate.rs"]
message = "Type relation code was changed"
message = "changes to the core type system"
cc = ["@compiler-errors", "@lcnr"]

[mentions."compiler/rustc_infer/src/infer/relate"]
message = "Type relation code was changed"
message = "changes to the core type system"
cc = ["@compiler-errors", "@lcnr"]

[mentions."compiler/rustc_middle/src/mir/interpret"]
Expand All @@ -484,6 +484,10 @@ cc = ["@rust-lang/miri"]
message = "Some changes occurred to MIR optimizations"
cc = ["@rust-lang/wg-mir-opt"]

[mentions."compiler/rustc_trait_selection/src/traits/wf.rs"]
message = "changes to the core type system"
cc = ["@compiler-errors", "@lcnr"]

[mentions."compiler/rustc_trait_selection/src/traits/const_evaluatable.rs"]
message = "Some changes occurred in `const_evaluatable.rs`"
cc = ["@BoxyUwU"]
Expand Down

0 comments on commit 9cb517a

Please sign in to comment.