Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression on MIR queries #99473

Open
Dylan-DPC opened this issue Jul 19, 2022 · 0 comments
Open

Regression on MIR queries #99473

Dylan-DPC opened this issue Jul 19, 2022 · 0 comments
Assignees
@oli-obk
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html perf-regression Performance regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Dylan-DPC
Copy link
Member

Dylan-DPC commented Jul 19, 2022 •
edited by oli-obk
Loading

@oli-obk @ouz-a can you open an issue to track the regression here? I'm nervous that this will just get lost.

Originally posted by @rylev in #98145 (comment)

The PR added a new Rvalue, which we will be able to remove once the derefer has been moved before borrowck and thus can be integrated into mir building. That should hopefully revert the regression
@Dylan-DPC Dylan-DPC mentioned this issue Jul 19, 2022
Merged
@oli-obk oli-obk self-assigned this Jul 19, 2022
@ouz-a ouz-a mentioned this issue Jul 20, 2022
Closed
@oli-obk oli-obk added the perf-regression Performance regression. label Dec 6, 2022
@Enselic Enselic added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html labels May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html perf-regression Performance regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Enselic @oli-obk @Dylan-DPC