Remove Rvalue::CopyForDeref

[ouz-a]

PR to test the performance impact of changes done in #98145 without a new Rvalue
as per #99473

r? @oli-obk

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

[oli-obk]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 5053cce with merge 667836735d44f254e53b10a1737e0d844e0f596b...

[bors]

☀️ Try build successful - checks-actions
Build commit: 667836735d44f254e53b10a1737e0d844e0f596b (667836735d44f254e53b10a1737e0d844e0f596b)

[rust-timer]

Queued 667836735d44f254e53b10a1737e0d844e0f596b with parent 03d488b, future comparison URL.

[rust-timer]

Finished benchmarking commit (667836735d44f254e53b10a1737e0d844e0f596b): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.7%	3.3%	2
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-8.5%	-8.9%	2
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	4.1%	7.9%	3
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.9%	-3.7%	2
Improvements 🎉 (secondary)	-2.7%	-2.7%	1
All 😿🎉 (primary)	1.3%	7.9%	5

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[ouz-a]

Closing this due to #99667