Rollup of 11 pull requests #105746
Merged
Rollup of 11 pull requests #105746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Okushi <[email protected]>
Added along with theme picker changes in e78f139, but no reason seems to have been given at the time for why this particular rule was added. Removing this rule results in `<kbd>` elements getting an I-bar, while the rule causes them to use the "default" arrow, but since selecting the text in these elements works fine, the I-bar is not misleading.
The type is already mentioned in the main message and the list of unmet bounds.
…: 0 }` This is the default CSS for `<pre>` tags in `.code-wrapper` anyway, so this line does nothing.
As a workaround for the full `#[refine]` semantics not being implemented yet, forbit returning a concrete future type like `Box<dyn Future>` or a manually implemented Future. `-> impl Future` is still permitted; while that can also cause accidental refinement, that's behind a different feature gate (`return_position_impl_trait_in_trait`) and that problem exists regardless of whether the trait method is async, so will have to be solved more generally. Fixes rust-lang#102745
No content is set, so this pseudo-element does not exist. The CSS was obsoleted by 73d0f7c.
…ler-errors Ensure async trait impls are async (or otherwise return an opaque type) As a workaround for the full `#[refine]` semantics not being implemented yet, forbit returning a concrete future type like `Box<dyn Future>` or a manually implemented Future. `-> impl Future` is still permitted; while that can also cause accidental refinement, that's behind a different feature gate (`return_position_impl_trait_in_trait`) and that problem exists regardless of whether the trait method is async, so will have to be solved more generally. Fixes rust-lang#102745
…e-fix, r=Nilstrieb Fix `-Z print-type-sizes` for generators with discriminant field ordered first Fixes rust-lang#105589 Fixes rust-lang#105591
…le, r=davidtwco Auto traits in `dyn Trait + Auto` are suggestable Not sure why I had made the `IsSuggestableVisitor` have that rule to not consider `dyn Trait + Auto` to be suggestable. It's possible that this was done because of the fact that we don't print the right parentheses for `&(dyn Trait + Auto)`, but that's a problem with printing these types in general that we probably have tracked somewhere else...
…li-obk Make `report_projection_error` more `Term` agnostic Fixes rust-lang#105632
…iasko Various cleanups to dest prop This makes fixing the issues identified in rust-lang#105577 easier. A couple changes - Use an enum with names instead of a bool - Only call `remove_candidates_if` from one place instead of two. Doing it from two places is far too fragile, since any divergence in the behavior between those callsites is likely to be unsound. - Remove `is_constant`. Right now we only merge locals, so this doesn't do anything, and the logic would be wrong if it did. r? `@tmiasko`
…-errors Add regression test for rust-lang#104678 Closes rust-lang#104678 r? `````@compiler-errors````` Signed-off-by: Yuki Okushi <[email protected]>
…jhpratt,GuillaumeGomez
rustdoc: remove unnecessary CSS `kbd { cursor: default }`
Added along with theme picker changes in https://github.com/rust-lang/rust/pull/47686/files#diff-7dc22a0530802d77c2f2ec9e834024a5657b6eab4055520fca46edc99a544413R1144, but no reason seems to have been given at the time for why this particular rule was added.
Removing this rule results in `<kbd>` elements getting an I-bar, while the rule causes them to use the "default" arrow, but since selecting the text in these elements works fine, the I-bar is not misleading.
… r=compiler-errors Do not mention long types in E0599 label The type is already mentioned in the main message and the list of unmet bounds.
…rors more clippy::complexity fixes r? ```@compiler-errors```
…-src-line-numbers, r=GuillaumeGomez
rustdoc: remove no-op CSS `.scrape-example .src-line-numbers { margin: 0 }`
This is the default CSS for `<pre>` tags in `.code-wrapper` anyway, so this line does nothing.
…re, r=GuillaumeGomez
rustdoc: remove no-op CSS `.item-info:before { color }`
No content is set, so this pseudo-element does not exist. The CSS was obsoleted by 73d0f7c.
rustbot
added
A-translation
|
@bors r+ rollup=never p=11 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 397b66e77b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Dec 15, 2022
|
Finished benchmarking commit (984eab5): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Z print-type-sizesfor generators with discriminant field ordered first #105623 (Fix-Z print-type-sizesfor generators with discriminant field ordered first)dyn Trait + Autoare suggestable #105627 (Auto traits indyn Trait + Autoare suggestable)report_projection_errormoreTermagnostic #105633 (Makereport_projection_errormoreTermagnostic)kbd { cursor: default }#105707 (rustdoc: remove unnecessary CSSkbd { cursor: default }).scrape-example .src-line-numbers { margin: 0 }#105724 (rustdoc: remove no-op CSS.scrape-example .src-line-numbers { margin: 0 }).item-info:before { color }#105730 (rustdoc: remove no-op CSS.item-info:before { color })Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup