Optimize hash map operations in the query system

[Zoxc]

This optimizes hash map operations in the query system by explicitly passing hashes and using more optimal operations. find_or_find_insert_slot in particular saves a hash table lookup over entry. It's not yet available in a safe API, but will be in rust-lang/hashbrown#466.

Benchmark	Before	After
	Time	Time	%
🟣 clap:check	1.6189s	1.6129s	-0.37%
🟣 hyper:check	0.2353s	0.2337s	-0.67%
🟣 regex:check	0.9344s	0.9289s	-0.59%
🟣 syn:check	1.4693s	1.4652s	-0.28%
🟣 syntex_syntax:check	5.6606s	5.6439s	-0.30%
Total	9.9185s	9.8846s	-0.34%
Summary	1.0000s	0.9956s	-0.44%

r? @cjgillot

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 936d8ad with merge d898dc6...

[bors]

☀️ Try build successful - checks-actions
Build commit: d898dc6 (d898dc6b90c747dee52de63fccc7f77f86171136)

[rust-timer]

Finished benchmarking commit (d898dc6): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.7%, 0.9%]	2
Improvements ✅ (primary)	-0.3%	[-0.5%, -0.3%]	14
Improvements ✅ (secondary)	-0.5%	[-0.9%, -0.2%]	25
All ❌✅ (primary)	-0.3%	[-0.5%, -0.3%]	14

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[3.1%, 3.5%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.615s -> 639.436s (1.40%)
Artifact size: 317.63 MiB -> 317.09 MiB (-0.17%)

[Zoxc]

This could use another perf run to see if using the sysroot hashbrown crate helps with bootstrap times.

[lqd]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 54d9510 with merge 2a31958...

[apiraino]

hello, checking progress. @Zoxc were are comments addressed? what's the current status? I'm looking at this one and I'm not sure. Also, pending a perf. triaging. thanks!

@rustbot author

[Zoxc]

I've changed it to use the new hashbrown HashTable type and removed the changes to the query caches. It needs some new performance measurements.

[Zoxc]

Benchmark	Before	After
	Time	Time	%
🟣 clap:check	1.5851s	1.5787s	-0.40%
🟣 hyper:check	0.2333s	0.2329s	-0.17%
🟣 regex:check	0.8890s	0.8853s	-0.41%
🟣 syn:check	1.4557s	1.4368s	💚 -1.30%
🟣 syntex_syntax:check	5.5859s	5.5620s	-0.43%
Total	9.7489s	9.6957s	-0.55%
Summary	1.0000s	0.9946s	-0.54%

A new perf run would be useful too.

[bors]

☔ The latest upstream changes (presumably #119549) made this pull request unmergeable. Please resolve the merge conflicts.

[Zoxc]

Ping for a new perf run.

[Kobzol]

@bors try @rust-timer queue

[bors]

⌛ Trying commit ca6f296 with merge 7e653fc...

[bors]

☀️ Try build successful - checks-actions
Build commit: 7e653fc (7e653fc3e20b4a90befe2f258e63896663e0e9b0)

[rust-timer]

Finished benchmarking commit (7e653fc): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	1
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	1
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	-0.2%	[-0.2%, -0.2%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	3.3%	[3.3%, 3.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-4.2%, -0.7%]	4
All ❌✅ (primary)	1.1%	[1.1%, 1.1%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 663.454s -> 666.358s (0.44%)
Artifact size: 308.30 MiB -> 308.36 MiB (0.02%)

[bors]

☔ The latest upstream changes (presumably #124558) made this pull request unmergeable. Please resolve the merge conflicts.

[JohnCSimon]

@Zoxc
ping from triage - can you post your status on this PR? This PR has not received an update in a few months.

[bors]

☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts.

[alex-semenyuk]

@Zoxc
Form wg-triage. Closed this PR due to inactivity. Feel free to reopen or raised new one. Thanks for your efforts.