Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hir::Node helper methods instead of repeating the same impl multiple times #122021

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Use hir::Node helper methods instead of repeating the same impl multiple times #122021

merged 2 commits into from
Mar 19, 2024

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 5, 2024

I wanted to do something entirely different and stumbled upon a bunch of cleanups

@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2024

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@oli-obk oli-obk changed the title Use hir::Node helper methods instead of repeat the same impl multiple times Use hir::Node helper methods instead of repeating the same impl multiple times Mar 5, 2024
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 5, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk oli-obk force-pushed the delangitemification branch from 5f24dd3 to 6baf7fd Compare March 5, 2024 16:06
@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@bors
Copy link
Contributor

bors commented Mar 15, 2024

☔ The latest upstream changes (presumably #122511) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors
compiler-errors approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long on this, r=me after rebase

@compiler-errors compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2024
oli-obk added 2 commits March 18, 2024 18:12
@oli-obk
Deduplicate associated_body and body_id
419d205 
They match on almost the same patterns, which is fishy.

Also turn `associated_body` into a method and do some cleanups nearby the call sites
@oli-obk
Use hir::Node helper methods instead of repeat the same impl multip…
69c4e81 
…le times

There already were inconsistencies, so this ensures we don't introduce subtle surprising bugs
@oli-obk oli-obk force-pushed the delangitemification branch from 6baf7fd to 69c4e81 Compare March 18, 2024 18:16
@rustbot
Copy link
Collaborator

rustbot commented Mar 18, 2024

Some changes occurred in coverage instrumentation.

cc @Zalathar

@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 18, 2024

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Mar 18, 2024

📌 Commit 69c4e81 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 18, 2024
@workingjubilee
Rollup merge of rust-lang#122021 - oli-obk:delangitemification, r=com…
d6a2918 
…piler-errors

Use hir::Node helper methods instead of repeating the same impl multiple times

I wanted to do something entirely different and stumbled upon a bunch of cleanups
@workingjubilee workingjubilee mentioned this pull request Mar 18, 2024
Closed
@bors
Copy link
Contributor

bors commented Mar 19, 2024

⌛ Testing commit 69c4e81 with merge f296c16...

@bors
Copy link
Contributor

bors commented Mar 19, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing f296c16 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 19, 2024
@bors bors merged commit f296c16 into rust-lang:master Mar 19, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 19, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f296c16): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.7% [2.7%, 2.7%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.396s -> 669.996s (0.09%)
Artifact size: 312.81 MiB -> 312.80 MiB (-0.00%)

@oli-obk oli-obk deleted the delangitemification branch March 19, 2024 15:48
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Mar 21, 2024
@bors
Auto merge of rust-lang#122021 - oli-obk:delangitemification, r=compi…
56288a7 
…ler-errors

Use hir::Node helper methods instead of repeating the same impl multiple times

I wanted to do something entirely different and stumbled upon a bunch of cleanups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rustbot @rust-log-analyzer @bors @rust-timer @compiler-errors