Fixup Apple target's description strings #130650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These commits modify compiler targets. |
rustbot
added
S-waiting-on-review
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@bors rollup |
jieyouxu
added
the
O-apple
taiki-e
reviewed
Sep 21, 2024
compiler/rustc_target/src/spec/targets/aarch64_apple_ios_macabi.rs
Outdated
Show resolved
Hide resolved
madsmtm
reviewed
Sep 21, 2024
BlackHoleFox
force-pushed
the
apple-target-desc-consistency
branch
from
d40f412 to
114093c
Compare
|
Thanks! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2024
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#130648 (move enzyme flags from general cargo to rustc-specific cargo) - rust-lang#130650 (Fixup Apple target's description strings) - rust-lang#130664 (Generate line numbers for non-rust code examples as well) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130669 (tests: Test that `extern "C" fn` ptrs lint on slices) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2024
Rollup merge of rust-lang#130650 - BlackHoleFox:apple-target-desc-consistency, r=jieyouxu Fixup Apple target's description strings Noticed this inconsistency in how the Apple target's had their new descriptions written while looking at rust-lang#130614, and figured it was easy enough to fixup shortly. I think prefixing every OS with `Apple` is clearer, especially for less known ones like `visionOS` and `watchOS`; so that's what was done here along with making the architecture names more consistent and then some other small tweaks. ~~r? `@thomcc~~` cc `@madsmtm`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this inconsistency in how the Apple target's had their new descriptions written while looking at #130614, and figured it was easy enough to fixup shortly. I think prefixing every OS with
Appleis clearer, especially for less known ones likevisionOSandwatchOS; so that's what was done here along with making the architecture names more consistent and then some other small tweaks.r? @thomcccc @madsmtm