Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more refactorings towards removing driver queries #132410

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Commits on Nov 9, 2024

  1. Let make_input immediately report an error for multiple input filenames

    This allows simplifying the call site and make_input by using a single
    match instead of two levels of if's.
    bjorn3 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    8fbe046 View commit details
    Browse the repository at this point in the history
  2. Don't mutably borrow GlobalCtxt in QueryResult::enter

    This allows re-entrant entering of the GlobalCtxt
    bjorn3 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    bec24a2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8e9bbc8 View commit details
    Browse the repository at this point in the history
  4. Reduce the amount of GlobalCtxt::enter calls in the driver

    We now only exit the GlobalCtxt when calling a callback and all the way
    at the end when the GlobalCtxt is about to be destroyed.
    bjorn3 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    1eece74 View commit details
    Browse the repository at this point in the history
  5. Pass TyCtxt instead of Queries to the after_analysis callbacks

    There is no other query that may need to be called at that point anyway.
    bjorn3 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    3b02a33 View commit details
    Browse the repository at this point in the history
  6. Deprecate the after_crate_root_parsing callback

    Several custom drivers are incorrectly calling queries.global_ctxt()
    from inside of it, which causes some driver code to be skipped. As such
    I would like to either remove it in the future or if custom drivers
    still need it, change it to accept an &rustc_ast::Crate instead.
    bjorn3 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    159ba4c View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Fix review comment

    bjorn3 committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    dc65c63 View commit details
    Browse the repository at this point in the history